Skip to content

Jaggi branch#15

Open
JKavuru-UCSC wants to merge 9 commits intomainfrom
Jaggi-Branch
Open

Jaggi branch#15
JKavuru-UCSC wants to merge 9 commits intomainfrom
Jaggi-Branch

Conversation

@JKavuru-UCSC
Copy link

Jaggi 02/28/2024: Created my own model, models/marts/finance/fct_orders_jk1.sql. As an experiment, in my fct_orders_jk1.sql model, I multiplied the amount by 100. In the original models/staging/stripe/stg_stripe__payments.sql model, the amount is divided by 100.

Copy link
Contributor

@tgraham-ucsc tgraham-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Jaggi - I went through the work so far, nice work, it looks as if the training is going well and you're making good progress.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well formatted, proper use of the ref function. Nice work!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, we want the the project_name to be relevant to the subject area, and we want to build the staging layer as views and the marts layer as tables. Nice work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model could be removed from the project as it's really just a placeholder for the project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model could be removed from the project as it's really just a placeholder for the project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can likely be removed as dbt will handle the table creation pieces

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice use of the source function. We could probably remove the commented block if this were not just training.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice use of the source function. We could probably remove the commented block if this were not just training.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, nice use of ref and I like how it pulls all of the components together for a final model.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see the enhancements in the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants